-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Rust toolchain to latest stable, using the minimal profile #571
Conversation
If I am not mistaken, `test-results-parser` is the only Rust package that is built from source, as `codecov-ribs` is consumed as a prebuilt binary from PyPI. As `test-results-parser` does not use any nightly features, this switches to the latest `stable` instead of pulling in an outdated nightly.
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #571 +/- ##
=======================================
Coverage 97.49% 97.49%
=======================================
Files 414 414
Lines 34982 34982
=======================================
Hits 34105 34105
Misses 877 877
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #571 +/- ##
=======================================
Coverage 97.49% 97.49%
=======================================
Files 414 414
Lines 34982 34982
=======================================
Hits 34105 34105
Misses 877 877
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #571 +/- ##
=======================================
Coverage 97.49% 97.49%
=======================================
Files 414 414
Lines 34982 34982
=======================================
Hits 34105 34105
Misses 877 877
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #571 +/- ##
=======================================
Coverage 97.54% 97.54%
=======================================
Files 449 449
Lines 36188 36188
=======================================
Hits 35299 35299
Misses 889 889
Flags with carried forward coverage won't be shown. Click here to find out more.
This change has been scanned for critical changes. Learn more |
If I am not mistaken,
test-results-parser
is the only Rust package that is built from source, ascodecov-ribs
is consumed as a prebuilt binary from PyPI.As
test-results-parser
does not use any nightly features, this switches to the lateststable
instead of pulling in an outdated nightly.Using the
minimal
profile here means that clippy, rustfmt or other tools are not being installed, speedings things up slightly.Going forward, I would recommend also consuming
test-results-parser
via prebuilt packages, in which case no Rust compiler would be needed in this docker image at all.